rpk: Enable key=value notation for every set command
#13325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful for negative values. And we are adding this format to every `set` command
Useful for negative values. And we are adding this format to every `set` command
gene-redpanda
approved these changes
Sep 7, 2023
twmb
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for using
<key>=<value>notation when using set commands, specifically this adds support for:rpk redpanda config setrpk cluster config setThis is particularly useful when setting negative values.
Fixes #12862
Backports Required
Release Notes
Improvements
rpk cluster config setandrpk redpanda config setnow support setting values using the format<key>=<value>